Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@greptile review |
|
@BugBot review |
PR SummaryLow Risk Overview Replaces Adds consistent request-scoped metadata ( Written by Cursor Bugbot for commit bb5702a. This will update automatically on new commits. Configure here. |
Greptile SummaryAdds Notable changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Route as execute/route.ts
participant Logger as Logger (module)
participant Child1 as reqLogger {requestId, workflowId}
participant Child2 as reqLogger {+userId, executionId}
participant Child3 as reqLogger {+workspaceId}
participant Executor as DAGExecutor / Engine / BlockExecutor
Route->>Logger: withMetadata({requestId, workflowId})
Logger-->>Child1: child logger
Route->>Child1: info("Starting server-side execution")
Route->>Child1: withMetadata({userId, executionId})
Child1-->>Child2: merged child logger
Route->>Child2: error("Workflow has no workspaceId") [if missing]
Route->>Child2: withMetadata({workspaceId})
Child2-->>Child3: merged child logger
Route->>Child3: info("Preprocessing passed")
Route->>Executor: new DAGExecutor(contextExtensions)
Executor->>Logger: withMetadata({workflowId, workspaceId, executionId, userId, requestId})
Logger-->>Executor: execLogger stored as field
Executor->>Executor: execLogger.info / warn / error (all log lines carry full context)
Reviews (4): Last reviewed commit: "Merge branch 'staging' into feat/improve..." | Re-trigger Greptile |
#3830) * improvement(sidebar): expand sidebar by hovering and clicking the edge * improvement(sidebar): add keyboard shortcuts for new workflow/task, center search modal, fix edge ARIA * improvement(sidebar): use Tooltip.Shortcut for inline shortcut display * fix(sidebar): change new workflow shortcut from Mod+Shift+W to Mod+Shift+P to avoid browser close-window conflict * fix(hotkeys): fall back to event.code for international keyboard layout compatibility * fix(sidebar): guard add-workflow shortcut with canEdit and isCreatingWorkflow checks
* feat(ui): handle image paste * Fix lint * Fix type error --------- Co-authored-by: Theodore Li <theo@sim.ai>
* feat(files): interactive markdown checkbox toggling in preview * fix(files): handle ordered-list checkboxes and fix index drift * lint * fix(files): remove counter offset that prevented checkbox toggling * fix(files): apply task-list styling to ordered lists too * fix(files): render single pass when interactive to avoid index drift * fix(files): move useMemo above conditional return to fix Rules of Hooks * fix(files): pass content directly to preview when not streaming to avoid stale frame
…sistency (#3831) * improvement(home): position @ mention popup at caret and fix icon consistency * fix(home): pin mirror div to document origin and guard button anchor * chore(auth): restore hybrid.ts to staging
|
@greptile review |
|
@greptile review |
|
@BugBot review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
* feat(logs): add additional metadata for workflow execution logs * Revert "Feat(logs) upgrade mothership chat messages to error (#3772)" This reverts commit 9d1b976. * Fix lint, address greptile comments * improvement(sidebar): expand sidebar by hovering and clicking the edge (#3830) * improvement(sidebar): expand sidebar by hovering and clicking the edge * improvement(sidebar): add keyboard shortcuts for new workflow/task, center search modal, fix edge ARIA * improvement(sidebar): use Tooltip.Shortcut for inline shortcut display * fix(sidebar): change new workflow shortcut from Mod+Shift+W to Mod+Shift+P to avoid browser close-window conflict * fix(hotkeys): fall back to event.code for international keyboard layout compatibility * fix(sidebar): guard add-workflow shortcut with canEdit and isCreatingWorkflow checks * feat(ui): handle image paste (#3826) * feat(ui): handle image paste * Fix lint * Fix type error --------- Co-authored-by: Theodore Li <theo@sim.ai> * feat(files): interactive markdown checkbox toggling in preview (#3829) * feat(files): interactive markdown checkbox toggling in preview * fix(files): handle ordered-list checkboxes and fix index drift * lint * fix(files): remove counter offset that prevented checkbox toggling * fix(files): apply task-list styling to ordered lists too * fix(files): render single pass when interactive to avoid index drift * fix(files): move useMemo above conditional return to fix Rules of Hooks * fix(files): pass content directly to preview when not streaming to avoid stale frame * improvement(home): position @ mention popup at caret and fix icon consistency (#3831) * improvement(home): position @ mention popup at caret and fix icon consistency * fix(home): pin mirror div to document origin and guard button anchor * chore(auth): restore hybrid.ts to staging * improvement(ui): sidebar (#3832) * Fix logger tests * Add metadata to mothership logs --------- Co-authored-by: Theodore Li <theo@sim.ai> Co-authored-by: Waleed <walif6@gmail.com> Co-authored-by: Theodore Li <theo@sim.ai>

Summary
We need additional observability into our system, even for successful calls.
Add additional logs for the /execute endpoint with metadata for user id, workflow id, workspace id, execution id. Reverted change to upgrade mothership chat logs to error.
I upgraded our logging system to INFO, so all logs should start showing up.
New formatting:
Type of Change
Testing
Ran workflow execution and validated new metadata logs are shown
Checklist
Screenshots/Videos